#312--add-credits-to-about-page #327
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
Jan 4, 2026
| class="HeaderLogo-module--logo--7060a HeaderLogo-module--monochrome--5dd53" | ||
| ><g fill="currentColor" | ||
| ><path | ||
| d="M4 266a14.002 14.002 0 0 0 14 14h8v-7h-8a6 6 0 0 1-6-6v-12h12v-7H12v-9h14v-7H4v34zm40 1a6.002 6.002 0 0 1-6 6h-2v-41h-8v48h10a14.002 14.002 0 0 0 14-14v-34h-8v35zm18-35h-8v48h8v-48zm10 0h-8v48h20v-7H72v-41zm42 5.24a13.172 13.172 0 0 0-10-5.24H94v48h8v-41h2c1.591 0 3.117.632 4.243 1.757A6.003 6.003 0 0 1 110 245v35h8v-35c0-1.591.632-3.117 1.757-4.243A6.003 6.003 0 0 1 124 239h2v41h8v-48h-10a13.176 13.176 0 0 0-10 5.24zm22 8.76v34h8v-17h8v17h8v-48h-10a13.996 13.996 0 0 0-9.899 4.101A13.996 13.996 0 0 0 136 246zm16 10h-8v-11c0-1.591.632-3.117 1.757-4.243A6.003 6.003 0 0 1 150 239h2v17zm20-24h-10v48h8v-17h2c1.591 0 3.117.632 4.243 1.757A6.003 6.003 0 0 1 178 269v11h8v-10a12.401 12.401 0 0 0-5.54-10.5A12.401 12.401 0 0 0 186 249v-3c0-3.713-1.475-7.274-4.101-9.899A13.996 13.996 0 0 0 172 232zm6 18a6.003 6.003 0 0 1-1.757 4.243A6.003 6.003 0 0 1 172 256h-2v-17h2c1.591 0 3.117.632 4.243 1.757A6.003 6.003 0 0 1 178 245v5zm10-11h6v41h8v-41h6v-7h-20v7zm30-7h-8v48h8v-48zm2 14v34h8v-16h8v16h8v-48h-10a13.996 13.996 0 0 0-9.899 4.101A13.996 13.996 0 0 0 220 246zm16 11h-8v-12c0-1.591.632-3.117 1.757-4.243A6.003 6.003 0 0 1 234 239h2v18zm26-19.36a15.64 15.64 0 0 0-12-5.64h-4v48h8v-39.35c4.12 1.71 8 6.53 8 11.35v28h8v-48h-8v5.64zM296 248v-4c0-9-4.28-13-12-13s-12 5.28-12 13c0 15 16 15.06 16 24v1c0 3-1 5-4 5s-4-2-4-5v-5h-8v4c0 9.08 4.28 13 12 13s12-5.28 12-13c0-14.94-16-15-16-24v-1c0-3 1-5 4-5s4 2 4 5v5h8zM100 100v28h47.7l-11.58-9.27 14.2-4.73-14.2-4.73L147.7 100H100zM48 72a6 6 0 0 0 3.333-1.011 6 6 0 0 0 2.21-2.693 6 6 0 0 0 .342-3.467 6 6 0 0 0-1.642-3.072 6 6 0 0 0-3.073-1.642 6 6 0 0 0-3.466.342 6 6 0 0 0-2.693 2.21A6 6 0 0 0 42 66a6 6 0 0 0 6 6zm0-10a4 4 0 0 1 2.222.674 4 4 0 0 1 1.473 1.795 4 4 0 0 1 .228 2.311 4 4 0 0 1-1.095 2.048 4 4 0 0 1-2.048 1.095 3.999 3.999 0 0 1-2.31-.227 4 4 0 0 1-1.796-1.474A4 4 0 0 1 44 66a4 4 0 0 1 1.172-2.828A4 4 0 0 1 48 62zm24 10a6 6 0 0 0 3.333-1.011 6 6 0 0 0 2.21-2.693 6 6 0 0 0 .342-3.467 6 6 0 0 0-1.642-3.072 6 6 0 0 0-3.072-1.642 6 6 0 0 0-3.467.342 6 6 0 0 0-2.693 2.21A6 6 0 0 0 66 66a6 6 0 0 0 6 6zm0-10a4 4 0 0 1 2.222.674 4 4 0 0 1 1.474 1.795 4 4 0 0 1 .227 2.311 4 4 0 0 1-1.095 2.048 4 4 0 0 1-2.048 1.095 3.999 3.999 0 0 1-2.31-.227 4 4 0 0 1-1.796-1.474A4 4 0 0 1 68 66a4 4 0 0 1 1.172-2.828A4 4 0 0 1 72 62z" |
Contributor
There was a problem hiding this comment.
SVG files must be in separated files
ai
reviewed
Jan 4, 2026
|
|
||
| async function getContributors(): Promise<Contributor[]> { | ||
| let response = await fetch( | ||
| 'https://api.github.com/repos/hplush/slowreader/contributors' |
Contributor
There was a problem hiding this comment.
We should do it in scripts, since sending new HTTP request on every page open will consume too many resources for static content like this one.
ai
reviewed
Jan 4, 2026
| } | ||
| } | ||
| .credits_close { |
Contributor
There was a problem hiding this comment.
I am trying to use a rule to not have styles in pages.
Let’s move it to Credits component (also CSS selectors must follow BEM).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.